Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean rebase of 1693 #1733

Merged
merged 1 commit into from
Mar 2, 2016
Merged

Clean rebase of 1693 #1733

merged 1 commit into from
Mar 2, 2016

Conversation

Aaronontheweb
Copy link
Member

Original commit message:

Have depended upon current implementations enumerable over values collections being in ascending order following a load of tests on the collections i performed elsewhere. This is not explicitly documented - but does follow the standard 'walk tree' behavior so is perhaps dependable.

I did not write any of this code - all credit is due to @MrTortoise.

All I did was use my git super powers to squash the commits on #1693

…lections being in ascending order following a load of tests on the collections i performed elsewhere.

This is not explicitly documented - but does follow the standard 'walk tree' behavior so is perhaps dependable.
@Aaronontheweb
Copy link
Member Author

Referencing the original issue too: #1676

Danthar added a commit that referenced this pull request Mar 2, 2016
@Danthar Danthar merged commit 7a11a93 into akkadotnet:dev Mar 2, 2016
@maxwellb
Copy link

maxwellb commented Mar 2, 2016

Bah, I commented in #1698 -- there's only 5 of them ;-)

The API changes look good. I ran Performance through NBench.. some tests have standard deviations thinner or wider, but averages/maxes don't seem to jump up in any alarming increments.

https://gist.github.com/maxwellb/c1eb44422427a52fa015

As noted in the gist, there is one failing test when I ran, but it was failing on dev, too, so ymmv?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants