Made JournalEntry.Payload an object and AtLeastOnceDeliverySemantic public #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
added a commit
that referenced
this pull request
Feb 16, 2016
…nd-atod-semantic-public Made JournalEntry.Payload an object and AtLeastOnceDeliverySemantic public
Horusiath
deleted the
persistence-sql-palyoad-obj-and-atod-semantic-public
branch
This was referenced Apr 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two changes:
JournalEntry.Payloadfield fromAkka.Persistence.Sql.Commonhas been made public. The reason behind it is that some database specific features (PostgreSQL JSON data type to be specific) expect from ADO.NET to pass column data instringformat instead ofbyte[].AtLeastOnceDeliverySemanticclass has been made public, so it can be encapsulated by any other actor (not only persistent actors) to enhance them with at-least-once-delivery semantic.None of these changes should break existing API.