Issue1202 boekabart #1645
Merged
Issue1202 boekabart #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is that a racy test or should I look into it? |
boekabart
force-pushed
the
issue1202_boekabart
branch
from
54283e5
to
4ebf611
Compare
This was referenced Jan 14, 2016
Closed
|
The test that failed initially might have been one of the racy Akka.Persistence tests that we know about - so no worries. However, could you please squash and rebase your commits? The steps for doing this are covered inside |
Changed fix for better consistency/comparability with the code just above Added unit test for 2 types of removals that used to return an unbalanced tree.
boekabart
force-pushed
the
issue1202_boekabart
branch
from
4ebf611
to
2e64c5e
Compare
|
Merging this, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1202 which was caused by Remove sometimes returning an unbalanced tree. This happened in after the 'core' remove, node X became unbalanced, and either X.L.R was higher than X.L.L or X.R.L was higher than X.R.R .
This has been reproduced in 2 unit tests.
Mostly this would not lead to a problem: a next remove or add would fix it, but in some cases (haven't been able to reproduce in a Unit Test, though) doing adds close to this tree (not to the tree itself!) would lead to a NullReferenceException when Rotating the now-unbalanced tree.
The fix is trivial: DoubleRotate should be done when the tree-after-remove is left (resp right) heavy - not only when it's left/right imbalanced. The helper functions were incorrectly named.