Implement enumerator for Composite ByteString. #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, just read the contributor's guide - I should have done this on a feature branch. That was a bit lazy of me. Sorry. |
Aaronontheweb
added a commit
that referenced
this pull request
Nov 12, 2015
Implement enumerator for Composite ByteString.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. I ran into this while working with Akka I/O (specifically, concatenated
ByteStrings can't be enumerated). I was going to add a couple of tests for this, but I see that the existing spec forByteStringdoesn't currently cover IEnumerable at all. I'm wondering if this is because there's a separate "iterator" implemented onByteString(a Scala artefact, perhaps?)...Anyway, let me know if some tests would be helpful, I don't mind writing them.