pass exception to NLogLogger exception logging #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, NLogLogger simply logs exception messages as strings.
This commit passes the exception to NLog as well. This allows
clients to use ${exception:...} layout renderers to choose if
they want to log exception details (including stack traces)
or not.
Aaronontheweb
added a commit
that referenced
this pull request
Jun 4, 2015
pass exception to NLogLogger exception logging
|
I'm thinking about this a bit more. It seems that the NLogLogger uses the LogEvent's Message property as the Message passed to NLog. However, LogEvent.ToString() provides a much richer message that includes the logger, correct thread id, etc. This is quite helpful (and in my apps, I'm using a custom logger for this reason specifically), and there are no real alternatives; NLog's layout renderers' ${threadid} won't have the correct thread id, as it'll be the id of the logging actor's thread, and not where the LogEvent originated. Would it be better if we logged LogEvent.ToString() as the message in NLogLogger? |
@ashic yes,I think so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, NLogLogger simply logs exception messages as strings. This commit passes the exception to NLog as well. This allows clients to use ${exception:...} layout renderers to choose if they want to log exception details (including stack traces) or not.