Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PubSub: Add support for emulator host variables #299

Merged
merged 1 commit into from
May 29, 2017
Merged

PubSub: Add support for emulator host variables #299

merged 1 commit into from
May 29, 2017

Conversation

danieletorelli
Copy link
Contributor

@danieletorelli danieletorelli commented May 11, 2017

Works whether the PUBSUB_EMULATOR_HOST variable is defined as a property or as environment variable.

Refs: #286

@lightbend-cla-validator

Hi @danieletorelli,

Thank you for your contribution! We really value the time you've taken to put this together.

We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it.
Please review the new CLA and sign it before we proceed with reviewing this pull request:

http://www.lightbend.com/contribute/cla

@danieletorelli
Copy link
Contributor Author

CLA signed.

@johanandren
Copy link
Member

Can we also use it for the tests?

@danieletorelli
Copy link
Contributor Author

Would be great but, if I remember well, the emulator would require an authenticated Google Cloud SDK on the workstation to work correctly. The purpose of this PR is to allow developers that already have valid GCloud credentials and active Pub/Sub services to emulate the production environment on the local machines.

@johanandren
Copy link
Member

Ah, thanks for clarifying.

Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patriknw patriknw merged commit 3993ce7 into akka:master May 29, 2017
@danieletorelli danieletorelli deleted the pubsub-emulator-host-variables branch May 29, 2017 15:57
@stephennancekivell
Copy link
Contributor

hey, nice addition @danieletorelli ! Its cool to see someone else is using this.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants