New api #23
New api #23
Conversation
- This closes #16
- Kafka-related properties are now grouped under ProducerProps - The API allows defining custom RequestStrategy in order to fine tune the performance - Old API becomes deprecated and will removed in future versions
- Kafka-related properties are now grouped under ConsumerProps - Old API becomes deprecated and will removed in future versions
- This allows spawning the actor as own child for supervision
| @@ -25,7 +25,6 @@ scalacOptions ++= Seq( | |||
| "-encoding", "UTF-8", // yes, this is 2 args | |||
| "-feature", | |||
| "-unchecked", | |||
| "-Xfatal-warnings", | |||
There was a problem hiding this comment.
just curious, what's the reason for this change?
There was a problem hiding this comment.
Original intent is to guard certain level of quality. This comes from a commercial project I've been working on where such set of flags does a good job. Do you see any concerns regarding this flag?
There was a problem hiding this comment.
Indeed that's a good intent. It's just that you are deleting the flag here.
There was a problem hiding this comment.
Right. I wanted to keep @deprecated method calls in tests which wouldn't compile with this flag. Ultimately I resigned from this idea so I can bring it back, thanks for pointing this out.
|
Some nice additions @kciesielski - looking forward to see them in the next version! |
|
Nothing more to add from me, the changes look good!! |
|
👍 looking good |
- We don't want this to get confused with Akka's Props
- We no longer call deprecated methods in tests
- Update to refactored properties class names - Provide new, clear examples of creating consumers / producers - Show the new way of reading from the end of the stream - Describe how to use custom dispatcher name
|
👍 |
This introduces new API for creating producers / consumers. - allows defining custom RequestStrategy - allows passing additional kafka-specific settings - allows setting custom dispatchers - allows custom error handling
This introduces new API for creating producers / consumers.