DXE-3087 Adds pending_changes computed field to Enrollment data source #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @joel-g, Thank you for your contribution. Please add unit tests and we will review it. Best regards, |
|
@Slonimskaia, I have added a check for the "pending_changes" field in the Enrollment tests following the pattern established in the Enrollments (plural) tests. |
mgwoj
changed the title
mgwoj
approved these changes
Sep 7, 2023
|
Hi @joel-g , Please fix test |
|
@mgwoj sorry I had a mistake in the name of the field in the test. I have fixed it. |
mgwoj
approved these changes
Sep 8, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enrollments (plural) data source returns instances with a computed field of "pending_changes". This field is missing from the individual Enrollment data source. This PR adds the missing field to the individual Enrollment data source.