Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing default value comment for ip_behavior #213

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Removing default value comment for ip_behavior #213

merged 1 commit into from
Oct 27, 2021

Conversation

lorenzoaiello
Copy link
Contributor

Removing default value comment for ip_behavior as there is no default configured in the resource configuration and the documented indicating a default value is confusing on whether it is actually a required field or not.

@lorenzoaiello
Copy link
Contributor Author

Build failure is not something caused by this PR or something I am able to fix.

$ make tools

make: *** No rule to make target `tools'.  Stop.

The command "make tools" failed and exited with 2 during .

@mgwoj mgwoj merged commit 0b0267f into akamai:master Oct 27, 2021
piotrpio pushed a commit that referenced this pull request Dec 6, 2021
@mgwoj @dstopka
Merge pull request #213 from lorenzoaiello/patch-2
b8857fa 
Removing default value comment for `ip_behavior`
@piotrpio piotrpio mentioned this pull request Dec 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lorenzoaiello @mgwoj @lkowalsk-akamai-com