-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow user specification of bin_dir, bin_name, and man_dir #561
Conversation
c8fb2f2
to
5de13be
Compare
Could you explain your use case?
|
My use case is a global install (Ie,
That's understandable, I didn't think about that particular use case. It seems reasonable to enforce the binary name anyways since it is the identity of the command.
While that's great for most users (myself generally included), there are many situations where it's better to let the user that knows what they are doing do what they want. Perhaps these directories aren't in their
While the script in the current installation recommendations couldn't write to directories without permission, the user can just as easily run
Here's a short list of well known installers that provide options to set installation directories. Sadly, I couldn't find any examples with man pages, as most
While there is little to no convention (sadly), quite a few other well known installers allow these settings, as it's a quite useful option. Additionally, these could be prefixed with |
I will note, and perhaps this should be a seperate issue/PR, that the installation directions call for running Perhaps an error should even be displayed and execution halted if not running in bash, as it's explicitly stated to run it in bash. (or else retrofit it to run in sh and change the directions) PS. |
This allows the user to choose the installation directory, the name of the executable, and the man directory using the environment variables BINDIR, BINNAME, and MANDIR, respectively.
This forces _bin_name to always be zoxide
This was missed in ac610f0
support for BINNAME has now been removed, and this has been rebased onto main. |
Sorry about the delay in replying, I've been incredibly busy.
The script is meant to be POSIX compliant, with the exception of the
That was very thorough, thank you! Personally, I think the Starship installer should be the way to go here. Command-line options are relatively more discoverable (using
|
@ajeetdsouza These have all been implemented in #590. I am closing this issue as that one take it's place. |
This allows the user to choose the installation directory, the name of the executable, and the
man
directory using the environment variablesBINDIR
,BINNAME
, andMANDIR
, respectively.