Restructure Assets & Scripts #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/Generate New Packages.bat # packages/clean_setup/clean_setup_customizations.xml # packages/terminal/terminal_customizations.xml # packages/terminal_plus/terminal_plus_customizations.xml # packages/vm_core/vm_core_customizations.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR restructures the assets and scripts in the repository. Assets and Scripts now have their own top level directory at the root of the project.
CABfiles are no longer included in repository. They must be compiled.Assetsdirectory at the root of the project stores project wide assets. This includes fonts, configurations, etc.Scriptsdirectory at the root of the project stores project wide scripts. This includes scripts for compilingCABfiles, and scripts that will be run when a package is installed on a client machine.core_assetsscript is used across all packages.Why
Moving assets and scripts into their own top level directory improves maintainability and readability. It's much easier to see all the different scripts, and manage assets. It was confusing when they were bundled with each package or kept under the
packagesdirectory.Other Details
A lot of things have been cleaned up, feel free to see all the changes for yourself. One thing to highlight is that Segoe UI Variable Font is no longer being deployed. It comes with Windows 11 and I'm planning on transitioning these packages to Windows 11 only in the future anyway.