Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix swiper component auto height problem. #2732

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from

Conversation

tinymins
Copy link

@tinymins tinymins commented May 7, 2018

Please makes sure the items are checked before submitting your PR, thank you!

  • [ x ] Rebase before creating a PR to keep commit history clear.
  • [ x ] Only One commit
  • [ x ] No eslint errors

I cannot figure out why height 'auto' will convert to '180px', but for compatibility reason I've modified the default value of 'height' from 'auto' to '180px' in order to make sure this commit will not affect those users who have already using this component with prop 'height' not set.

@tinymins
Copy link
Author

tinymins commented May 7, 2018

#2731 , btw, this branch failed travis-ci since commit 883264f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant