Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass logger to confluent producer and consumer #1464

Merged
merged 10 commits into from
May 25, 2024
Merged

Conversation

kumaranvpl
Copy link
Contributor

@kumaranvpl kumaranvpl commented May 24, 2024

Description

Please include a summary of the change and specify which issue is being addressed. Additionally, provide relevant motivation and context.

Fixes #1449

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-analysis.sh
  • I have included code examples to illustrate the modifications

@kumaranvpl kumaranvpl requested a review from Lancetnik May 24, 2024 07:33
@kumaranvpl kumaranvpl added bug Something isn't working enhancement New feature or request Confluent Issues related to `faststream.confluent` module labels May 24, 2024
@kumaranvpl kumaranvpl marked this pull request as draft May 24, 2024 07:34
@kumaranvpl kumaranvpl marked this pull request as ready for review May 24, 2024 07:48
@Lancetnik Lancetnik added this pull request to the merge queue May 25, 2024
Merged via the queue into main with commit 1237edb May 25, 2024
31 checks passed
@Lancetnik Lancetnik deleted the pass-logger-to-confluent branch May 25, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Confluent Issues related to `faststream.confluent` module enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Provide a way to customize logging in confluent's Consumer and Producer objects
2 participants