-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[86] Ignore [String]
JWK parameters
#116
Merged
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8daa41d
Add failing test case for the problem
xavierLowmiller 96fe42f
Provide a workaround for X509CertificateChain
xavierLowmiller 9da0b25
Move test case
xavierLowmiller a271bdd
Add workaround for private keys, too
xavierLowmiller 2346cdb
Ignore .keyOperations (key_ops), too
xavierLowmiller 4495ec2
Extract constant
xavierLowmiller File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
// | ||
// JWKx5cTests.swift | ||
// Tests | ||
// | ||
// Created by Xaver Lohmüller on 12.10.18. | ||
// | ||
|
||
import XCTest | ||
@testable import JOSESwift | ||
|
||
class JWKx5cTests: XCTestCase { | ||
func testBuildingJWKSetShouldNotFailIfCertificatesArePresent() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This test would probably fit nicely into |
||
XCTAssertNoThrow(try JWKSet(data: json)) | ||
} | ||
} | ||
|
||
private let json = """ | ||
{ | ||
"keys": [{ | ||
"kty": "RSA", | ||
"e": "AQAB", | ||
"use": "enc", | ||
"x5t": "eGydA5CgawshHa8ULkMyn5gl9eI", | ||
"kid": "kid-12345", | ||
"x5c": ["Y2VydGlmaWNhdGUxMjM0NWRhdGEx"], | ||
"n": "4r7_nnmRn9hppkfxt8p" | ||
}, { | ||
"kty": "RSA", | ||
"e": "AQAB", | ||
"use": "sig", | ||
"x5t": "gpYbURn6jaHwNX9xhE2MGCIXPd0", | ||
"kid": "kid-12346", | ||
"x5c": ["Y2VydGlmaWNhdGUxMjM0NWRhdGEy"], | ||
"n": "rTZj4tESZaNMpwsj" | ||
}] | ||
} | ||
""".data(using: .utf8)! |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also ignore the
keyOperations
parameter, it is an array of strings as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be awesome if you could also add the workaround to the decoding of
RSAPrivateKey
here.