[MapMarker] fix android release crash on custom marker #1643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopherdro
approved these changes
Sep 14, 2017
|
Thanks for merging this. had to use Geor23's fork till now. |
pjaraherrera
pushed a commit
to pjaraherrera/react-native-maps
that referenced
this pull request
Sep 27, 2017
sorodrigo
pushed a commit
to Vizzuality/react-native-maps
that referenced
this pull request
Oct 23, 2017
…into upstream-update * 'master' of https://github.com/airbnb/react-native-maps: v0.17.0 Update index.d.ts v0.16.4 [MapMarker] fix android release crash on custom marker (react-native-maps#1643) Add support for animateToViewingAngle and animateToBearing for Android Bump 0.16.3 Revert "[MapView] revert initialRegion change (react-native-maps#1613)" [MapView] revert initialRegion change (react-native-maps#1613) Added missing satellite option for iOS Google Maps (react-native-maps#1603) Remove legalNotice from android AirMapModule As per https://developers.google.com/android/reference/com/google/android/gms/common/GooglePlayServicesUtil this information does not need to be displayed in app. Set initial region on view (react-native-maps#1579) Added Typescript Definitions Updated "showsIndoorLevelPicker" documentation. Added [iOS / Google Maps] support for showsIndoorLevelPicker. Fall back to View.propTypes if ViewPropTypes is not available (react-native-maps#1473) (react-native-maps#1474) fixe mistakes on circle.md (react-native-maps#1584) Add support for AirMap (Native IOS Maps) as suggested on the PR comments. Adds support to animateToBearing and animateToViewingAngle functions on IOS. fix rare android crashes when map size is 0 Remove caret from "react": "^16.0.0-alpha.12"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an error on Android release mode when the Map.Marker has children.
From Geor23@a83c04a
Closes #907