Disabling retry_persistent_connection in Tests

[ShubhAgarwal-dev]

What do these changes do?

It disables retry logic by default in tests.

Are there changes in behavior for the user?

No

Is it a substantial burden for the maintainers to support this?

No

Related issue number

#9141

Checklist

• I think the code is well written
• Unit tests for the changes exist
• Add a new news fragment into the CHANGES/ folder
• Documentation reflects the changes
• If you provide code modification, please add yourself to CONTRIBUTORS.txt

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.57%. Comparing base (21f5f92) to head (8b2a662).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #9396   +/-   ##
=======================================
  Coverage   98.57%   98.57%           
=======================================
  Files         107      107           
  Lines       35048    35050    +2     
  Branches     4150     4150           
=======================================
+ Hits        34547    34549    +2     
  Misses        334      334           
  Partials      167      167           

Flag	Coverage Δ
CI-GHA	98.45% <100.00%> (+<0.01%)	⬆️
OS-Linux	98.11% <100.00%> (+<0.01%)	⬆️
OS-Windows	96.53% <100.00%> (+<0.01%)	⬆️
OS-macOS	97.80% <100.00%> (-0.02%)	⬇️
Py-3.10.11	96.09% <100.00%> (-1.58%)	⬇️
Py-3.10.15	97.60% <100.00%> (+<0.01%)	⬆️
Py-3.11.10	97.68% <100.00%> (+<0.01%)	⬆️
Py-3.11.9	97.74% <100.00%> (-0.02%)	⬇️
Py-3.12.6	98.16% <100.00%> (+<0.01%)	⬆️
Py-3.13.0-rc.3	98.15% <100.00%> (+<0.01%)	⬆️
Py-3.9.13	97.56% <100.00%> (+<0.01%)	⬆️
Py-3.9.20	97.50% <100.00%> (+<0.01%)	⬆️
Py-pypy7.3.16	97.12% <100.00%> (+<0.01%)	⬆️
VM-macos	97.80% <100.00%> (-0.02%)	⬇️
VM-ubuntu	98.11% <100.00%> (+<0.01%)	⬆️
VM-windows	96.53% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ShubhAgarwal-dev]

Hi @Dreamsorcerer, I will make all the suggested changes. I saw many tests are using this ClientSession class, should I make these changes everywhere..?

Also, how to pass the Label/Backport Label Check?

Thanks for the inputs

[ShubhAgarwal-dev]

Hi @Dreamsorcerer, I have made all the suggested changes.

[Dreamsorcerer]

There are a fair number of tests which create a ClientSession directly, but this should cover most tests.

We just want a test now to validate the behaviour in tests.

[Dreamsorcerer]

We just want a test now to validate the behaviour in tests.

I'll probably take a look at it over the weekend, but if you'd like to give it a try, then I think we want a test that uses the aiohttp_client fixture with an app that has an endpoint which closes the connection (probably request.close()) and then assert that the client only made one request.

[ShubhAgarwal-dev]

Ok, I will try to make a test like that. Can you point me to parts where I can take a look for inspiration while writing tests..?

[Dreamsorcerer]

Probably any test that uses aiohttp_client currently. The test should be added to test_test_utils.py