Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM: Migrate to using propcache for property caching #9394

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 2, 2024

What do these changes do?

aio-libs/yarl#1070 (comment)
Replaces reify with a shared implementation called propcache that will be maintained in a single place for yarl and aiohttp

Are there changes in behavior for the user?

The propcache dep is now required

Related issue number

aio-libs/yarl#1070 (comment)

@bdraco bdraco added the backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot label Oct 2, 2024
requirements/constraints.txt Outdated Show resolved Hide resolved
requirements/constraints.txt Outdated Show resolved Hide resolved
requirements/cython.txt Outdated Show resolved Hide resolved
requirements/cython.txt Outdated Show resolved Hide resolved
requirements/dev.txt Outdated Show resolved Hide resolved
requirements/dev.txt Outdated Show resolved Hide resolved
requirements/doc.txt Outdated Show resolved Hide resolved
requirements/doc.txt Outdated Show resolved Hide resolved
requirements/lint.txt Outdated Show resolved Hide resolved
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.58%. Comparing base (8a8913b) to head (1f99f58).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9394      +/-   ##
==========================================
+ Coverage   98.57%   98.58%   +0.01%     
==========================================
  Files         107      107              
  Lines       35037    34973      -64     
  Branches     4150     4143       -7     
==========================================
- Hits        34536    34478      -58     
+ Misses        334      330       -4     
+ Partials      167      165       -2     
Flag Coverage Δ
CI-GHA 98.46% <100.00%> (+0.01%) ⬆️
OS-Linux 98.13% <100.00%> (+0.01%) ⬆️
OS-Windows 96.55% <100.00%> (+0.02%) ⬆️
OS-macOS 97.82% <100.00%> (+0.02%) ⬆️
Py-3.10.11 97.69% <100.00%> (+0.01%) ⬆️
Py-3.10.15 97.62% <100.00%> (+0.01%) ⬆️
Py-3.11.10 97.69% <100.00%> (+0.01%) ⬆️
Py-3.11.9 97.76% <100.00%> (+0.02%) ⬆️
Py-3.12.6 98.18% <100.00%> (+0.01%) ⬆️
Py-3.13.0-rc.2 98.16% <100.00%> (+0.01%) ⬆️
Py-3.9.13 97.59% <100.00%> (+0.02%) ⬆️
Py-3.9.20 97.52% <100.00%> (+0.01%) ⬆️
Py-pypy7.3.16 97.14% <100.00%> (+0.02%) ⬆️
VM-macos 97.82% <100.00%> (+0.02%) ⬆️
VM-ubuntu 98.13% <100.00%> (+0.01%) ⬆️
VM-windows 96.55% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant