-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DNM: Migrate to using propcache for property caching #9394
Draft
bdraco
wants to merge
6
commits into
master
Choose a base branch
from
propcache
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
added
the
backport-3.11
Trigger automatic backporting to the 3.11 release branch by Patchback robot
label
Oct 2, 2024
31 tasks
bdraco
commented
Oct 2, 2024
bdraco
commented
Oct 2, 2024
bdraco
commented
Oct 2, 2024
bdraco
commented
Oct 2, 2024
bdraco
commented
Oct 2, 2024
bdraco
commented
Oct 2, 2024
bdraco
commented
Oct 2, 2024
bdraco
commented
Oct 2, 2024
bdraco
commented
Oct 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9394 +/- ##
==========================================
+ Coverage 98.57% 98.58% +0.01%
==========================================
Files 107 107
Lines 35037 34973 -64
Branches 4150 4143 -7
==========================================
- Hits 34536 34478 -58
+ Misses 334 330 -4
+ Partials 167 165 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
aio-libs/yarl#1070 (comment)
Replaces
reify
with a shared implementation calledpropcache
that will be maintained in a single place foryarl
andaiohttp
Are there changes in behavior for the user?
The
propcache
dep is now requiredRelated issue number
aio-libs/yarl#1070 (comment)