Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #7368/8a8913b backport][3.11] Fixed failure to try next host after single-host connection timeout #9391

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 1, 2024

Co-authored-by: Sam Bull git@sambull.org
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: J. Nick Koston nick@koston.org
(cherry picked from commit 8a8913b)

…7368)

Co-authored-by: Sam Bull <git@sambull.org>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: J. Nick Koston <nick@koston.org>
(cherry picked from commit 8a8913b)
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 1, 2024
@bdraco bdraco changed the title Fixed failure to try next host after single-host connection timeout (#7368) [PR #7368/8a8913b backport][3.11] Fixed failure to try next host after single-host connection timeout Oct 1, 2024
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.81%. Comparing base (8ab799a) to head (ae65b47).
Report is 1 commits behind head on 3.11.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.11    #9391   +/-   ##
=======================================
  Coverage   97.80%   97.81%           
=======================================
  Files         108      108           
  Lines       35098    35142   +44     
  Branches     4190     4194    +4     
=======================================
+ Hits        34327    34373   +46     
+ Misses        574      573    -1     
+ Partials      197      196    -1     
Flag Coverage Δ
CI-GHA 97.68% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.37% <100.00%> (+<0.01%) ⬆️
OS-Windows 94.88% <100.00%> (+0.01%) ⬆️
OS-macOS 97.07% <100.00%> (+0.01%) ⬆️
Py-3.10.11 96.92% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 96.86% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 96.95% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.01% <100.00%> (+<0.01%) ⬆️
Py-3.12.6 97.41% <100.00%> (+<0.01%) ⬆️
Py-3.13.0-rc.2 97.39% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.84% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 96.78% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 96.39% <100.00%> (+<0.01%) ⬆️
VM-macos 97.07% <100.00%> (+0.01%) ⬆️
VM-ubuntu 97.37% <100.00%> (+<0.01%) ⬆️
VM-windows 94.88% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review October 2, 2024 01:24
@bdraco bdraco merged commit 71fe3be into 3.11 Oct 2, 2024
34 of 35 checks passed
@bdraco bdraco deleted the patchback/backports/3.11/8a8913be2eefca3d7504880a235664f5dc44f076/pr-7368 branch October 2, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants