Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9372/0416d28 backport][3.10] Only prepare proxy headers for a request if a proxy is set #9376

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 1, 2024

(cherry picked from commit 0416d28)

@bdraco bdraco requested a review from asvetlov as a code owner October 1, 2024 16:53
@bdraco bdraco changed the title Only prepare proxy headers for a request if a proxy is set (#9372) [PR #9372/0416d28 backport][3.101] Only prepare proxy headers for a request if a proxy is set Oct 1, 2024
@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Oct 1, 2024
@bdraco bdraco changed the title [PR #9372/0416d28 backport][3.101] Only prepare proxy headers for a request if a proxy is set [PR #9372/0416d28 backport][3.10] Only prepare proxy headers for a request if a proxy is set Oct 1, 2024
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.78%. Comparing base (7019054) to head (a29b822).
Report is 2 commits behind head on 3.10.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.10    #9376   +/-   ##
=======================================
  Coverage   97.78%   97.78%           
=======================================
  Files         108      108           
  Lines       34886    34887    +1     
  Branches     4174     4174           
=======================================
+ Hits        34114    34115    +1     
  Misses        574      574           
  Partials      198      198           
Flag Coverage Δ
CI-GHA 97.67% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.35% <100.00%> (+<0.01%) ⬆️
OS-Windows 94.97% <ø> (+<0.01%) ⬆️
OS-macOS 97.05% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 96.91% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 96.85% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 96.93% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.00% <100.00%> (+<0.01%) ⬆️
Py-3.12.6 97.39% <100.00%> (+<0.01%) ⬆️
Py-3.13.0-rc.2 97.37% <100.00%> (+<0.01%) ⬆️
Py-3.8.10 94.36% <ø> (+<0.01%) ⬆️
Py-3.8.18 96.64% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.83% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 96.77% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 96.37% <100.00%> (+<0.01%) ⬆️
VM-macos 97.05% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.35% <100.00%> (+<0.01%) ⬆️
VM-windows 94.97% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 57ce46c into 3.10 Oct 1, 2024
37 of 38 checks passed
@bdraco bdraco deleted the patchback/backports/3.10/0416d28a5ec6faa5619a34c6f406ca669d292202/pr-9372 branch October 1, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant