Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary generator expression to generate the connection key #9358

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Remove unnecessary generator expression to generate the connection key #9358

merged 1 commit into from
Sep 30, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 30, 2024 •
edited
Loading

Wrapping the dict items in a tuple is enough

@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Sep 30, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.56%. Comparing base (5762ed6) to head (a9c0128).
Report is 7 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #9358   +/-   ##
=======================================
  Coverage   98.56%   98.56%           
=======================================
  Files         107      107           
  Lines       34947    34949    +2     
  Branches     4147     4138    -9     
=======================================
+ Hits        34444    34446    +2     
  Misses        335      335           
  Partials      168      168
Flag Coverage Δ
CI-GHA 98.44% <100.00%> (+<0.01%) ⬆️
OS-Linux 98.10% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.51% <100.00%> (-0.01%) ⬇️
OS-macOS 97.78% <100.00%> (-0.01%) ⬇️
Py-3.10.11 97.67% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 97.60% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 97.66% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.74% <100.00%> (+<0.01%) ⬆️
Py-3.12.6 98.15% <100.00%> (+<0.01%) ⬆️
Py-3.13.0-rc.2 98.13% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.56% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 97.50% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 97.11% <100.00%> (+<0.01%) ⬆️
VM-macos 97.78% <100.00%> (-0.01%) ⬇️
VM-ubuntu 98.10% <100.00%> (+<0.01%) ⬆️
VM-windows 96.51% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review September 30, 2024 23:06
@bdraco bdraco merged commit a50ca6c into master Sep 30, 2024
41 of 42 checks passed
@bdraco bdraco deleted the remove_uneeded_genexp branch September 30, 2024 23:06
@patchback Patchback
Copy link
Contributor

patchback bot commented Sep 30, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/a50ca6cec2eaec4184fc9119e1f0e09b11d46d1a/pr-9358

Backported as #9361

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 30, 2024
@bdraco @patchback
Remove unnecessary generator expression to generate the connection key (
e427321 
#9358)

(cherry picked from commit a50ca6c)
@patchback patchback bot mentioned this pull request Sep 30, 2024
Merged
@patchback Patchback
Copy link
Contributor

patchback bot commented Sep 30, 2024 •
edited
Loading

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/a50ca6cec2eaec4184fc9119e1f0e09b11d46d1a/pr-9358

Backported as #9362

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 30, 2024
@bdraco @patchback
Remove unnecessary generator expression to generate the connection key (
5b632e7 
#9358)

(cherry picked from commit a50ca6c)
@patchback patchback bot mentioned this pull request Sep 30, 2024
Merged
bdraco added a commit that referenced this pull request Sep 30, 2024
@patchback @bdraco
[PR #9358/a50ca6ce backport][3.10] Remove unnecessary generator expre…
b4a8083 
…ssion to generate the connection key (#9361)

Co-authored-by: J. Nick Koston <nick@koston.org>
bdraco added a commit that referenced this pull request Sep 30, 2024
@patchback @bdraco
[PR #9358/a50ca6ce backport][3.11] Remove unnecessary generator expre…
354153e 
…ssion to generate the connection key (#9362)

Co-authored-by: J. Nick Koston <nick@koston.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz approved these changes

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdraco @webknjaz