Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add set_content_disposition test #8332

Merged
merged 8 commits into from
Apr 15, 2024

Conversation

Olegt0rr
Copy link
Contributor

@Olegt0rr Olegt0rr commented Apr 15, 2024

What do these changes do?

Add tests, checking set_content_disposition() case works properly

Are there changes in behavior for the user?

Is it a substantial burden for the maintainers to support this?

Related issue number

Relates #8326

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

    • if you don't have an issue number, change it to the pull request
      number after creating the PR

      • .bugfix: A bug fix for something the maintainers deemed an
        improper undesired behavior that got corrected to match
        pre-agreed expectations.
      • .feature: A new behavior, public APIs. That sort of stuff.
      • .deprecation: A declaration of future API removals and breaking
        changes in behavior.
      • .breaking: When something public is removed in a breaking way.
        Could be deprecated in an earlier release.
      • .doc: Notable updates to the documentation structure or build
        process.
      • .packaging: Notes for downstreams about unobvious side effects
        and tooling. Changes in the test invocation considerations and
        runtime assumptions.
      • .contrib: Stuff that affects the contributor experience. e.g.
        Running tests, building the docs, setting up the development
        environment.
      • .misc: Changes that are hard to assign to any of the above
        categories.
    • Make sure to use full sentences with correct case and punctuation,
      for example:

      Fixed issue with non-ascii contents in doctest text files
      -- by :user:`contributor-gh-handle`.

      Use the past tense or the present tense a non-imperative mood,
      referring to what's changed compared to the last released version
      of this project.

@Olegt0rr

This comment has been minimized.

@Olegt0rr
Copy link
Contributor Author

Ah, found _is_form_data bool that changes behaviour

@Dreamsorcerer
Copy link
Member

Dreamsorcerer commented Apr 15, 2024

Strange behaviour, the same test within TestMultipartWriter class and with writer fixture passes! 😱

writer isn't initialised as form-data.

@Dreamsorcerer Dreamsorcerer added backport-3.9 Trigger automatic backporting to the 3.9 release branch by Patchback robot backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot labels Apr 15, 2024
aiohttp/multipart.py Outdated Show resolved Hide resolved
@Olegt0rr Olegt0rr requested a review from webknjaz as a code owner April 15, 2024 15:42
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Apr 15, 2024
@Dreamsorcerer Dreamsorcerer merged commit 482e6cd into aio-libs:master Apr 15, 2024
36 of 37 checks passed
Copy link
Contributor

patchback bot commented Apr 15, 2024

Backport to 3.9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.9/482e6cdf6516607360666a48c5828d3dbe959fbd/pr-8332

Backported as #8333

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 15, 2024
Copy link
Contributor

patchback bot commented Apr 15, 2024

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/482e6cdf6516607360666a48c5828d3dbe959fbd/pr-8332

Backported as #8334

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 15, 2024
Dreamsorcerer pushed a commit that referenced this pull request Apr 15, 2024
…8334)

**This is a backport of PR #8332 as merged into master
(482e6cd).**

Co-authored-by: Oleg A <t0rr@mail.ru>
@Olegt0rr Olegt0rr deleted the test-content-dispositions branch April 15, 2024 17:40
Dreamsorcerer pushed a commit that referenced this pull request Apr 15, 2024
…8333)

**This is a backport of PR #8332 as merged into master
(482e6cd).**

Co-authored-by: Oleg A <t0rr@mail.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.9 Trigger automatic backporting to the 3.9 release branch by Patchback robot backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants