-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only install async-timeout for Python < 3.11 #7556
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7556 +/- ##
=======================================
Coverage 97.35% 97.35%
=======================================
Files 106 106
Lines 31481 31501 +20
Branches 3575 3583 +8
=======================================
+ Hits 30648 30668 +20
Misses 630 630
Partials 203 203
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I think, this could be tagged for a backport to |
Great, thanks. |
Backport to 3.9: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply db2c274 on top of patchback/backports/3.9/db2c274c91d17eb410225d504c83d4bd6971d0ae/pr-7556 Backporting merged PR #7556 into master
🤖 @patchback |
Replace `async-timeout` with `asyncio.timeout` for Python 3.11+. Overall the change isn't as clean as I would have liked it to be. That's mostly a result of the name conflict with `timeout`. I'm open for suggestions on how to improve it. `async-timeout` won't be a dependency for Python 3.11+ any longer. Fixes: aio-libs#7502 (cherry picked from commit db2c274)
…7558) Replace `async-timeout` with `asyncio.timeout` for Python 3.11+. Overall the change isn't as clean as I would have liked it to be. That's mostly a result of the name conflict with `timeout`. I'm open for suggestions on how to improve it. `async-timeout` won't be a dependency for Python 3.11+ any longer. Fixes: #7502 (cherry picked from commit db2c274)
What do these changes do?
Replace
async-timeout
withasyncio.timeout
for Python 3.11+.Overall the change isn't as clean as I would have liked it to be. That's mostly a result of the name conflict with
timeout
. I'm open for suggestions on how to improve it.Are there changes in behavior for the user?
async-timeout
won't be a dependency for Python 3.11+ any longer.Related issue number
Fixes: #7502