Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #7348/bf9d753e backport][3.9] 🐛 Fix RST in changelog template before links #7350

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Jul 8, 2023

This is a backport of PR #7348 as merged into master (bf9d753).

In corner cases, changelog fragments with things like detached link definitions (example: #7346) cause RST rendering errors. This patch corrects this by injecting empty lines between the changelog entry bodies and their reference lists.

@codecov
Copy link

codecov bot commented Jul 8, 2023

Codecov Report

Merging #7350 (5914b5f) into 3.9 (64a8daa) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              3.9    #7350   +/-   ##
=======================================
  Coverage   97.28%   97.28%           
=======================================
  Files         107      107           
  Lines       31581    31581           
  Branches     4008     4008           
=======================================
  Hits        30724    30724           
  Misses        651      651           
  Partials      206      206           
Flag Coverage Δ
CI-GHA 97.23% <ø> (ø)
OS-Linux 96.91% <ø> (ø)
OS-Windows 94.54% <ø> (ø)
OS-macOS 96.60% <ø> (ø)
Py-3.10.11 94.45% <ø> (ø)
Py-3.10.12 96.79% <ø> (ø)
Py-3.11.0 96.52% <ø> (ø)
Py-3.8.10 94.42% <ø> (ø)
Py-3.8.17 96.73% <ø> (ø)
Py-3.9.13 94.43% <ø> (ø)
Py-3.9.17 96.76% <ø> (ø)
Py-pypy7.3.11 94.16% <ø> (+0.01%) ⬆️
VM-macos 96.60% <ø> (ø)
VM-ubuntu 96.91% <ø> (ø)
VM-windows 94.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@webknjaz webknjaz merged commit aed1f0e into 3.9 Jul 8, 2023
25 of 27 checks passed
@webknjaz webknjaz deleted the patchback/backports/3.9/bf9d753edc928e7ecbc590c32603ebd3c1fc6282/pr-7348 branch July 8, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant