Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust type annotations making print arg optional in web.run_app() #7190

Conversation

kohtala
Copy link
Contributor

@kohtala kohtala commented Feb 3, 2023

PR #3690 by @dutradda

Backport to 3.9 to fix #7077.
Upgrade isort 5.11.4 for poetry compatibility fix PyCQA/isort#2077

(cherry picked from commit baddbfe)

What do these changes do?

Fix #7077 by fixing the backport.

Are there changes in behavior for the user?

No longer give false typing error.

Related issue number

#7077

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

PR aio-libs#3690 by @dutradda

Backport to 3.9 to fix aio-libs#7077.
Upgrade isort 5.11.4 for poetry compatibility fix PyCQA/isort#2077

(cherry picked from commit baddbfe)
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Feb 3, 2023
@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Merging #7190 (2fd61f9) into 3.9 (0d93d80) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              3.9    #7190      +/-   ##
==========================================
+ Coverage   97.26%   97.35%   +0.08%     
==========================================
  Files         107      107              
  Lines       31264    31264              
  Branches     3961     3961              
==========================================
+ Hits        30410    30437      +27     
+ Misses        643      621      -22     
+ Partials      211      206       -5     
Flag Coverage Δ
CI-GHA 97.24% <ø> (+0.07%) ⬆️
OS-Linux 96.92% <ø> (+0.04%) ⬆️
OS-Windows 94.51% <ø> (+0.17%) ⬆️
OS-macOS 96.48% <ø> (?)
Py-3.10.9 96.97% <ø> (+0.04%) ⬆️
Py-3.11.0 95.38% <ø> (ø)
Py-3.7.15 96.72% <ø> (ø)
Py-3.7.9 94.36% <ø> (?)
Py-3.8.10 94.28% <ø> (+<0.01%) ⬆️
Py-3.8.16 96.62% <ø> (+0.12%) ⬆️
Py-3.9.13 94.28% <ø> (?)
Py-3.9.16 96.64% <ø> (+0.02%) ⬆️
Py-pypy7.3.11 94.07% <ø> (?)
VM-macos 96.48% <ø> (?)
VM-ubuntu 96.92% <ø> (+0.04%) ⬆️
VM-windows 94.51% <ø> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/web.py 99.16% <ø> (+1.66%) ⬆️
tests/autobahn/test_autobahn.py 98.33% <0.00%> (ø)
tests/test_connector.py 97.73% <0.00%> (+0.13%) ⬆️
aiohttp/web_protocol.py 89.50% <0.00%> (+0.29%) ⬆️
tests/test_run_app.py 97.31% <0.00%> (+0.59%) ⬆️
tests/conftest.py 96.19% <0.00%> (+5.71%) ⬆️
tests/autobahn/client/client.py 96.42% <0.00%> (+49.99%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Dreamsorcerer Dreamsorcerer merged commit e0a7865 into aio-libs:3.9 Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants