Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the order of checks in test_proxy_functional #6072

Merged

Conversation

webknjaz
Copy link
Member

Apparently, if an exception gets raised before the warning gets a
chance to be emitted, it doesn't emit an assertion error. Pytest bug?

(cherry picked from commit 1097473)

What do these changes do?

This patch fixes a bug in tests added in #5992 that I discovered while
preparing a backport in #6049.

Are there changes in behavior for the user?

No.

Related issue number

N/A

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

Apparently, if an exception gets raised before the warning gets a
chance to be emitted, it doesn't emit an assertion error. Pytest bug?

(cherry picked from commit 1097473)
@webknjaz webknjaz added bot:chronographer:skip This PR does not need to include a change note backport:skip Skip backport bot labels Oct 11, 2021
@webknjaz webknjaz enabled auto-merge (squash) October 11, 2021 00:52
@webknjaz webknjaz self-assigned this Oct 11, 2021
@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #6072 (ef07082) into master (4ebd52e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6072      +/-   ##
==========================================
- Coverage   93.31%   93.31%   -0.01%     
==========================================
  Files         102      102              
  Lines       30062    30062              
  Branches     2690     2683       -7     
==========================================
- Hits        28053    28051       -2     
- Misses       1833     1836       +3     
+ Partials      176      175       -1     
Flag Coverage Δ
unit 93.24% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_proxy_functional.py 63.15% <100.00%> (ø)
tests/test_run_app.py 86.05% <0.00%> (-0.60%) ⬇️
aiohttp/client_ws.py 21.96% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ebd52e...ef07082. Read the comment docs.

@webknjaz webknjaz merged commit 9723abf into aio-libs:master Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip Skip backport bot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant