Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] Use pip-tools to pin dependencies (#5389) #5427

Merged
merged 1 commit into from
Jan 22, 2021
Merged

Conversation

greshilov
Copy link
Contributor

What do these changes do?

Backport #5408

Are there changes in behavior for the user?

Related issue number

#5389

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jan 21, 2021
@greshilov
Copy link
Contributor Author

greshilov commented Jan 21, 2021

@webknjaz unfortunately tests fail for python3.6 due to the previous commit.

from multidict import CIMultiDictProxy

CIMultiDictProxy[str]  # TypeError: 'type' object is not subscriptable

Should aiohttp 3.8 support python3.6?

@webknjaz
Copy link
Member

webknjaz commented Jan 22, 2021

Should aiohttp 3.8 support python3.6?

I think so. You should probably throw in another ignore just for this branch. But FWIW it's not related to this specific backport and should be submitted separately.

@webknjaz webknjaz merged commit e82eac8 into aio-libs:3.8 Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants