[WIP] Complete chunked request on server eof #5238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov Report
@@ Coverage Diff @@
## master #5238 +/- ##
=======================================
Coverage 97.54% 97.54%
=======================================
Files 43 43
Lines 8794 8796 +2
Branches 1413 1414 +1
=======================================
+ Hits 8578 8580 +2
Misses 101 101
Partials 115 115
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Hello， is this PR ready to be merged? |
|
@greshilov Want to revive this PR? |
|
@alexmac this may prove interesting |
1 task
Dreamsorcerer
added a commit
that referenced
this pull request
Nov 3, 2023
Fixes #5220. I believe this is a better fix than #5238. That PR detects that we didn't finish sending a chunked response and then closes the connection. This PR ensures that we simply complete the chunked response by sending the EOF bytes, allowing the connection to remain open and be reused normally.
|
Superseded by #7764 . |
Dreamsorcerer
added a commit
that referenced
this pull request
Nov 3, 2023
Fixes #5220. I believe this is a better fix than #5238. That PR detects that we didn't finish sending a chunked response and then closes the connection. This PR ensures that we simply complete the chunked response by sending the EOF bytes, allowing the connection to remain open and be reused normally. (cherry picked from commit 9c07121)
Dreamsorcerer
added a commit
that referenced
this pull request
Nov 3, 2023
Fixes #5220. I believe this is a better fix than #5238. That PR detects that we didn't finish sending a chunked response and then closes the connection. This PR ensures that we simply complete the chunked response by sending the EOF bytes, allowing the connection to remain open and be reused normally. (cherry picked from commit 9c07121)
xiangxli
pushed a commit
to xiangxli/aiohttp
that referenced
this pull request
Dec 4, 2023
Fixes aio-libs#5220. I believe this is a better fix than aio-libs#5238. That PR detects that we didn't finish sending a chunked response and then closes the connection. This PR ensures that we simply complete the chunked response by sending the EOF bytes, allowing the connection to remain open and be reused normally. (cherry picked from commit 9c07121)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Possible fix #5220
Code is hacky and questionable, hope maintainers will help.
Are there changes in behavior for the user?
No.
Related issue number
#5220
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.