Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HEAD requests for static content #4813

Merged
merged 4 commits into from
Oct 15, 2020
Merged

Fix HEAD requests for static content #4813

merged 4 commits into from
Oct 15, 2020

Commits on Jun 10, 2020

  1. Fix HEAD requests for static content 

    FileResponse directly injects the response into the socket with
sendfile() (if it can), which bypasses the checks in Response that
prevent any content being sent for HEAD requests and for 204 (No
Content) and 304 (Not Modified) responses. I've duplicated that logic
into FileResponse. I'm not sure if the status checks are actually
applicable (since StaticResource already has its own handling for Not
Modified) and I don't currently have any tests for them.

Closes aio-libs#4809.
    @bmerry
    bmerry committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    81a2fe6 View commit details
    Browse the repository at this point in the history

  2. Add myself to CONTRIBUTORS.txt

    @bmerry
    bmerry committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    40e5b64 View commit details
    Browse the repository at this point in the history

  3. Fix unit test for Python 3.6 

    StreamWriter.wait_closed doesn't exist on 3.6.
    @bmerry
    bmerry committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    98591ab View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2020

  1. Merge branch 'master' into fix-4809

    @asvetlov
    asvetlov authored Oct 15, 2020
    Configuration menu
    Copy the full SHA
    42e3314 View commit details
    Browse the repository at this point in the history