Add the URL to the ClientResponseError repr string

aio-libs · Aug 10, 2019 · 38a1ec4 · 38a1ec4
1 parent df30472
commit 38a1ec4
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/CHANGES/3959.bugfix b/CHANGES/3959.bugfix
@@ -0,0 +1 @@
+Add URL to the string representation of ClientResponseError.
diff --git a/CONTRIBUTORS.txt b/CONTRIBUTORS.txt
@@ -69,6 +69,7 @@ David Bibb
 David Michael Brown
 Denilson Amorim
 Denis Matiychuk
+Dennis Kliban
 Dima Veselov
 Dimitar Dimitrov
 Diogo Dutra da Mata

diff --git a/aiohttp/client_exceptions.py b/aiohttp/client_exceptions.py
@@ -61,7 +61,8 @@ def __init__(self, request_info: RequestInfo,
         self.headers = headers
         self.history = history
 
-        super().__init__("%s, message='%s'" % (self.status, message))
+        super().__init__("%s, message='%s', url='%s" %
+                         (self.status, message, request_info.real_url))
 
 
 class ContentTypeError(ClientResponseError):

diff --git a/tests/test_client_exceptions.py b/tests/test_client_exceptions.py
@@ -1,5 +1,7 @@
 """Tests for client_exceptions.py"""
 
+from unittest import mock
+
 from yarl import URL
 
 from aiohttp import client
@@ -21,13 +23,15 @@ def test_invalid_url() -> None:
 
 
 def test_response_default_status() -> None:
+    request_info = mock.Mock(real_url='http://example.com')
     err = client.ClientResponseError(history=None,
-                                     request_info=None)
+                                     request_info=request_info)
     assert err.status == 0
 
 
 def test_response_status() -> None:
+    request_info = mock.Mock(real_url='http://example.com')
     err = client.ClientResponseError(status=400,
                                      history=None,
-                                     request_info=None)
+                                     request_info=request_info)
     assert err.status == 400