-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add agent type #1142
base: master
Are you sure you want to change the base?
Add agent type #1142
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1142 +/- ##
==========================================
+ Coverage 79.70% 79.74% +0.03%
==========================================
Files 141 142 +1
Lines 9851 9884 +33
==========================================
+ Hits 7852 7882 +30
- Misses 1999 2002 +3 ☔ View full report in Codecov by Sentry. |
fedot/api/main.py
Outdated
NB! 'adaptive_mutation_type' and 'context_agent_type' can be specified with 'composer_tuner_params'. | ||
With default 'adaptive_mutation_type' context agent is not used, however, when 'adaptive_mutation_type' | ||
is specified as not a default one be careful choosing 'context_agent_type' | ||
since the default one is only considering the number of nodes in graph. | ||
The full range of context agents can be obtained here: golem.core.optimizers.adaptive.context_agents |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Вряд ли этот комментарий кому-то пригодиться. Его с разбегу поймешь только ты, мне пришлось 5 раз вчитаться, Люба еще поймет. А те кто не знает -- им это не поможет и только вызовет больше вопросов. Предлагаю написать что-нибудь краткое, что поймет потенциальный рядовой пользователь и без технических деталей. Мол, "экспериментальная функциональность для адаптивной эволюции.... За деталями -- туда-то"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
available_operations += self.advisor.models | ||
if self.advisor.data_operations: | ||
available_operations += self.advisor.data_operations | ||
return available_operations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Можешь рассказать, для чего этот метод потенциально нужен?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
там чтобы получать ембеддинги графов нужно либо иметь выбранный контекстнуальный агент как синглтон (чтобы он помнил все операции/модели в графах, что через него проходили), либо изначально подавать ему список всех доступных операций
@@ -160,6 +160,10 @@ class Fedot: | |||
Default optimizer is :class:`~golem.core.optimisers.genetic.gp_optimizer.EvoGraphOptimizer`. | |||
See the `example \ | |||
<https://github.com/aimclub/FEDOT/blob/master/examples/advanced/fedot_based_solutions/external_optimizer.py>`_ | |||
|
|||
NB! 'adaptive_mutation_type' and 'context_agent_type' can be specified with 'composer_tuner_params'. | |||
Both these params are a part of experimental functionality for adaptive evolution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Может быть все-таки добавить что-то типа: "...Both these params are a part of experimental functionality for adaptive evolution. Adaptive evolution uses multi-armed bandits to choose most promising mutation at each iteration...."?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
как скажете
a6e0764
to
0be3b10
Compare
Hello @maypink! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2023-12-07 10:59:34 UTC |
Add adaptive optimization params in FEDOT + Method for getting all available operations from node factory