Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around CPython bug in HTTPError #58

Merged
merged 4 commits into from
Mar 12, 2023

Conversation

Zac-HD
Copy link
Contributor

@Zac-HD Zac-HD commented Mar 12, 2023

Workaround for python/cpython#98778 (aka python/cpython#90113), in order to fix pytest-dev/pytest#10797.

This is a little ugly but I thought we'd prefer to keep it tightly scoped rather than suppressing anything raised by getattr().

@coveralls
Copy link

coveralls commented Mar 12, 2023

Pull Request Test Coverage Report for Build 4399424903

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 236 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.3%) to 65.224%

Files with Coverage Reduction New Missed Lines %
/opt/hostedtoolcache/PyPy/3.8.16/x64/lib/pypy3.8/site-packages/exceptiongroup/_exceptions.py 1 89.86%
/opt/hostedtoolcache/Python/3.7.15/x64/lib/python3.7/site-packages/exceptiongroup/_formatting.py 45 69.68%
/opt/hostedtoolcache/Python/3.8.16/x64/lib/python3.8/site-packages/exceptiongroup/_formatting.py 45 69.87%
/opt/hostedtoolcache/Python/3.9.16/x64/lib/python3.9/site-packages/exceptiongroup/_formatting.py 46 69.87%
/opt/hostedtoolcache/PyPy/3.8.16/x64/lib/pypy3.8/site-packages/exceptiongroup/_formatting.py 99 16.99%
Totals Coverage Status
Change from base Build 4115259050: -0.3%
Covered Lines: 2065
Relevant Lines: 3166

💛 - Coveralls

@agronholm
Copy link
Owner

I'm a bit confused. There was only a new test added?

@Zac-HD
Copy link
Contributor Author

Zac-HD commented Mar 12, 2023

I wanted to see CI fail on old versions before pushing the fix, and... it's not failing yet 😅

@Zac-HD
Copy link
Contributor Author

Zac-HD commented Mar 12, 2023

@agronholm done, albeit with two more commits than I'd planned.

@agronholm agronholm merged commit 95b7819 into agronholm:main Mar 12, 2023
@agronholm
Copy link
Owner

Thanks!

@agronholm
Copy link
Owner

I almost missed the wrong hyperlink format in the changelog. Fixing.

@agronholm
Copy link
Owner

Released v1.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rendering the traceback of an HTTPError causes in INTERNALERROR
3 participants