Spring Cleanup #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nmeum
commented
Apr 11, 2024
•
nmeum
commented
- More smart constructors to make the EDSL less verbose (most of these are generated using template-haskell)
- Hide more Haskell modules, in the hopes of making it easier to document the API using Haddock in the future
- Get rid of some (now unused) dependencies
nmeum
force-pushed
the
expression-template-haskell
branch
from
560d8db
to
54506e4
Compare
Most importantly, don't export the loader and generator modules.
Allows us to not export the LibRISCV.Utils module.
nmeum
force-pushed
the
expression-template-haskell
branch
from
a4e4038
to
2009d51
Compare
nmeum
changed the title
nmeum
force-pushed
the
expression-template-haskell
branch
from
a6a17d5
to
409af05
Compare
Currently, it is not possible to define custom semantics outside of the LibRISCV code (this may change in the future!) and for building interpreters, the semantics modules do not need to be accessible as these interpreters are defined in terms of the provided language primitives.
nmeum
force-pushed
the
expression-template-haskell
branch
from
752cb72
to
bdc57df
Compare
nmeum
force-pushed
the
expression-template-haskell
branch
from
213532d
to
8adff3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.