Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVED] All the completion blocks from the API are now nonnull #341

Merged
merged 2 commits into from
Aug 5, 2016
Merged

[IMPROVED] All the completion blocks from the API are now nonnull #341

merged 2 commits into from
Aug 5, 2016

Conversation

radazzouz
Copy link
Contributor

All completion blocks need to be nonnull. Otherwise, the 1Password
extension cannot reply after it has been completed by the user.

Rad Azzouz added 2 commits August 5, 2016 13:10
Merge branch 'master' into rad/the-competion-blocks-need-to-be-nonnull
1a0111d
[IMPROVED] All the completion blocks from the API are now nonnull
7f726ae 
All completion blocks need to be `nonnull`. Otherwise, the 1Password
extension cannot reply after it has been completed by the user.
@radazzouz radazzouz self-assigned this Aug 5, 2016
@radazzouz
Copy link
Contributor Author

Nice catch @nathanvf 👍 !

@radazzouz radazzouz merged commit e54afff into master Aug 5, 2016
@radazzouz radazzouz deleted the rad/the-competion-blocks-need-to-be-nonnull branch August 8, 2016 13:32
radazzouz pushed a commit that referenced this pull request Aug 9, 2016
[RELEASE] 1.8.3
db3c5b2 
[NEW] Added typedefs for completion blocks for more flexibility. {#339}

[IMPROVED] Updated the Javascript code for Web View Filling. {#335}
[IMPROVED] All the completion blocks from the API are now `nonnull`. {#341}

[FIXED] Fixed minor typo in the documentation. {#340}
@radazzouz radazzouz mentioned this pull request Aug 9, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@radazzouz radazzouz

Labels
done fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@radazzouz