Fixing HeaderDoc invalid documentation #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much for taking the time to submit a PR, @glentregoning 👍 The changes look great. However, we prefer to keep Xcode's defaults, as far as Clang warnings are concerned. So could you please remove Have an Awesome weekend! |
Remove enabling CLANG_WARN_DOCUMENTATION_COMMENTS warning
|
Ok @radazzouz I've updated the PR and removed CLANG_WARN_DOCUMENTATION_COMMENTS = YES |
|
Thanks for the quick response @glentregoning 👍 Cheers! |
radazzouz
added a commit
that referenced
this pull request
Jan 31, 2016
Enabling documentation warnings, and fixing HeaderDoc invalid documentation
radazzouz
changed the title
radazzouz
pushed a commit
that referenced
this pull request
Feb 15, 2016
```
[IMPROVED] Improved compatibility with CocoaPods 1.0.0. {#302}
[IMPROVED] Updated the Javascript code for Web View Filling. {#303}
[IMPROVED] Improved the instructions for the Rich Icons submission in the Best Practice section. {#290}
[IMPROVED] Updated the documentation to mention all the required frameworks to link for projects targeting iOS 7.1 or earlier. {#294, #296}
[IMPROVED] Improved the header documentation. {#298}
[IMPROVED] Listing all the required frameworks in the podspec file. {#297}
[IMPROVED] Removed extra new lines for a clearer code and README. {#293}
[IMPROVED] Removed usless semicolons from Swift code. {#295}
[FIXED] Fixed status bar inconsistencies between the Objective-C and the Swift versions of ACME. {#292}
[FIXED] Fixed outdated header comments for the demo apps. {#299}
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extension triggers warnings when compiled with CLANG_WARN_DOCUMENTATION_COMMENTS=true.
This PR fixes the warnings and enables this warning by default (to help avoid this issue in future).