Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Boolean Rings #1146

Merged
merged 6 commits into from
Sep 6, 2024
Merged

Add Boolean Rings #1146

merged 6 commits into from
Sep 6, 2024

Conversation

Freek98
Copy link
Contributor

@Freek98 Freek98 commented Aug 7, 2024

This PR introduces Boolean rings as idempotent commutative rings.

We then proceed to show these rings allow for the usual symbols and satisfy the usual axioms for boolean algebras.

@felixwellen felixwellen self-assigned this Aug 8, 2024
Copy link
Collaborator

@felixwellen felixwellen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Only some nit-picking comments...

Cubical/Algebra/BooleanRing/Base.agda Outdated Show resolved Hide resolved
Cubical/Algebra/BooleanRing/Base.agda Outdated Show resolved Hide resolved
Cubical/Algebra/BooleanRing/Base.agda Show resolved Hide resolved
Cubical/Algebra/BooleanRing/Base.agda Outdated Show resolved Hide resolved
Cubical/Algebra/BooleanRing/Base.agda Outdated Show resolved Hide resolved
Cubical/Algebra/BooleanRing/Base.agda Show resolved Hide resolved
Cubical/Algebra/BooleanRing/Base.agda Outdated Show resolved Hide resolved
Cubical/Algebra/BooleanRing/Base.agda Show resolved Hide resolved
Cubical/Algebra/BooleanRing/Base.agda Outdated Show resolved Hide resolved
Cubical/Algebra/BooleanRing/Base.agda Show resolved Hide resolved
@felixwellen felixwellen merged commit 760a894 into agda:master Sep 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants