Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve things #61

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Improve things #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a69069
Remove duplicate og:site_name meta tag and update comment style
afnizarnur Apr 25, 2024
da37e31
Update meta.json and base.njk files
afnizarnur Apr 25, 2024
62a0c2a
Update Twitter meta tags
afnizarnur Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/data/meta.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"title": "Afnizar Nur Ghifari, Product Designer",
"title": "Afnizar Nur Ghifari",
"description": "Afnizar Nur Ghifari is an Indonesia-based product designer that specializing in user interfaces, design system, and strategy across multiple industries.",
"url": "https://afnizarnur.com",
"lang": "en",
Expand Down
7 changes: 3 additions & 4 deletions src/includes/meta.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,18 @@ endset -%}
/>
<meta property="og:site_name" content="{{ meta.title }}"/>
<meta property="og:locale" content="{{ meta.locale }}"/>
<meta property="og:site_name" content="{{ meta.title }}"/>
<meta name="author" content="{{ author.name }}"/>
<meta
property="og:image"
content="{{ 'https://afnizarnur.com/assets/images/meta-image.png' | url }}"
/>

<!-- Twitter -->
{# Twitter #}
<meta property="twitter:card" content="summary_large_image"/>
<meta name="twitter:site" content="@{{ author.social.twitter.name }}"/>
<meta name="twitter:creator" content="@{{ author.social.twitter.name }}"/>
<meta property="twitter:title" content="{{ meta.title }}"/>
<meta property="twitter:description" content="{{ meta.description }}"/>
<meta property="twitter:title" content="{{ title or meta.title }}"/>
<meta property="twitter:description" content="{{ description or meta.description }}"/>
<meta
property="twitter:image"
content="{{ 'https://afnizarnur.com/assets/images/meta-image.png' | url }}"
Expand Down
19 changes: 17 additions & 2 deletions src/layouts/base.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,24 @@
<meta charset="UTF-8"/>
<meta name="viewport" content="width=device-width, initial-scale=1.0"/>
<title>
{% if title %}{{ title }} | {{ meta.title }}
{% if page
.url
.startsWith('/writing/') %}
{% if page.url == '/writing/' or page
.url
.startsWith('/writing/tags/') %}
{{ title }} · {{ meta.title }}
{% else %}
{% if title %}
{{ title }}
{% endif %}
{% endif %}
{% else %}
{{ meta.title }}
{% if title %}
{{ title }} · {{ meta.title }}
{% else %}
{{ meta.title }}
{% endif %}
{% endif %}
</title>
{% include "meta.njk" %}
Expand Down
42 changes: 21 additions & 21 deletions src/site.webmanifest
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,23 @@
{
"lang": "en",
"dir": "ltr",
"name": "Afnizar Nur Ghifari, Product Designer",
"short_name": "afnizarnur",
"icons": [
{
"src": "/assets/images/favicon/android-chrome-192x192.png",
"sizes": "192x192",
"type": "image/png"
},
{
"src": "/assets/images/favicon/android-chrome-512x512.png",
"sizes": "512x512",
"type": "image/png"
}
],
"theme_color": "#191a1b",
"background_color": "#ffffff",
"start_url": "/index.html",
"display": "standalone",
"orientation": "natural"
"lang": "en",
"dir": "ltr",
"name": "Afnizar Nur Ghifari",
"short_name": "afnizarnur",
"icons": [
{
"src": "/assets/images/favicon/android-chrome-192x192.png",
"sizes": "192x192",
"type": "image/png"
},
{
"src": "/assets/images/favicon/android-chrome-512x512.png",
"sizes": "512x512",
"type": "image/png"
}
],
"theme_color": "#191a1b",
"background_color": "#ffffff",
"start_url": "/index.html",
"display": "standalone",
"orientation": "natural"
}