separate crun out of MonadTypedStore #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrigue
reviewed
Jul 11, 2024
There was a problem hiding this comment.
The changes concerning the interface and the models are ok, but in example_typed_store, it would be better to distinguish between the parts that use crun and those that do not. In particular, all the programs should be defined using only typedStoreMonad, and some theorems do not require it either. Maybe this can be done in another PR, as this requires reorganizing the code.
|
By the way, I also see some |
|
@garrigue I have made changes according to your suggestions. Almost everything was straightforward, but one proof needed a small change. |
|
@t6s LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits MonadTypedStore in the hierarchy into MonadTypedStore and MonadTypedStoreRun.