fix: nx.del not exist value should work

afeiship · Aug 7, 2024 · 2042975 · 2042975
1 parent 9c2a7c8
commit 2042975
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 3 deletions.
diff --git a/__tests__/base/nx.del.test.js b/__tests__/base/nx.del.test.js
@@ -1,5 +1,6 @@
 const nx = require('../../dist/index');
 
+// /Users/a7/github/next/__tests__/base/nx.del.test.js
 describe('nx.get name/path', () => {
   test('nx.del should worked', () => {
     var obj = { name: 'afeiship', a: { b: { c: 'c-value' } } };
@@ -10,5 +11,11 @@ describe('nx.get name/path', () => {
     expect(obj).toEqual({ name: 'afeiship', a: { b: {} } });
   });
 
+  test('del path has not exists value should get false', () => {
+    const obj = { name: 'afei' };
+    const res1 = nx.del(obj, 'preferences_tag.US');
+    expect(res1).toBe(false);
+  });
+
   // https://github.com/sindresorhus/dot-prop/blob/master/test.js
 });
diff --git a/dist/index.js b/dist/index.js
@@ -235,7 +235,8 @@ else if (freeModule) {
       var path = paths[i];
 
       if (i === paths.length - 1) {
-        delete inTarget[path];
+        if (inTarget == null) return false;
+        if (typeof inTarget === 'object') delete inTarget[path];
         return true;
       }
       inTarget = inTarget[path];

diff --git a/dist/index.min.js b/dist/index.min.js
diff --git a/src/core.js b/src/core.js
@@ -177,7 +177,8 @@
       var path = paths[i];
 
       if (i === paths.length - 1) {
-        delete inTarget[path];
+        if (inTarget == null) return false;
+        if (typeof inTarget === 'object') delete inTarget[path];
         return true;
       }
       inTarget = inTarget[path];