Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for Marlin/issues/23926 #1

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Conversation

aegelsky
Copy link
Owner

Requirements

Proposed fix for this issue:
MarlinFirmware#23926

Description

just repeting what I wrote in that issue:

when using in Configuration.h (attached below):

#define MOTHERBOARD BOARD_MKS_GEN_L
#define EXTRUDERS 2

it uses pins_MKS_GEN_L.h, which in turn uses pins_RAMPS.h,
where FET_ORDER_EEB is selected (which is right), but pins in RAMPS and MKS GEN L don't match in second extruder:

#elif FET_ORDER_EEB // Hotend, Hotend, Bed
#define HEATER_1_PIN MOSFET_B_PIN
#define HEATER_BED_PIN MOSFET_C_PIN

#elif FET_ORDER_EEB // Hotend, Hotend, Bed
#define FAN_PIN 4 // IO pin. Buffer needed

(from pins_RAMPS.h)

this leads to:
HEATER_1_PIN = 9
FAN_PIN = 4

actual MKS GEN L pins map:
https://github.com/makerbase-mks/MKS-GEN_L/blob/master/hardware/MKS%20Gen_L%20V1.0_008/MKS%20Gen_L%20V1.0_008%20PIN.pdf

pin D9 is fan pin and D4 is servo pin, so when enabling second extruder heater, fan turns ON and there is no way to power on fan.
(also I wouldn't power up extruder heater from fan socket, it very possibly might no handle 40W output)

adding this into pins_MKS_GEN_L.h (from line 40) fixes this issue:

// Hotend, Hotend, Bed + Fan on D9
#if FET_ORDER_EEB
#define MOSFET_B_PIN 7
#define FAN_PIN 9
#endif

Benefits

it sets proper pins for second extruder and fan when using two heaters, bed and fan

Configurations

Configuration.zip

Related Issues

MarlinFirmware#23926

@aegelsky aegelsky merged commit f1e02c6 into bugfix-2.0.x Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant