New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New loading before rendering #59

Open

Marc-Andrieu wants to merge 1 commit into main from loading

Contributor

Marc-Andrieu commented Sep 29, 2024

Fix #47: see my comment there.

Content of this PR:

Putting the fallback of <SuspenseEmbed> to <></>: no annoying "Loading..." anymore.
Adding pure CSS skeletons that match perfectly ("at least on my machine") the shape of the <FormLabel> and <FormControl> of the <LoginCustomFormField>: this way, there's no more dependency and the size of the <CenteredCard> is preserved.
Version +2 because I forgot to update it in my previous PR.

We may want some refactoring later for the CSS and the <Suspense>-derived tags...


          New loading before rendering

570d5ec

Marc-Andrieu added the help wanted label

Contributor Author

Marc-Andrieu commented Sep 30, 2024

How the skeletons render on my phone:

I artificially made them last a bit longer here for the video's sake.
If you zoom and use slow motion, it's imperceptibly taller with the skeletons.

Screen_Recording_20240930_212317_Ecosia.mp4

Marc-Andrieu added the release label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted release