esm: fix globalPreload warning

PR-URL: nodejs#49069 Fixes: nodejs#49026 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Jacob Smith <jacob@frende.me>
aduh95 · Aug 13, 2023 · b5da2f4 · b5da2f4
1 parent 9fc5700
commit b5da2f4
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 8 deletions.
diff --git a/lib/internal/modules/esm/hooks.js b/lib/internal/modules/esm/hooks.js
@@ -86,7 +86,6 @@ let importMetaInitializer;
 
 // [2] `validate...()`s throw the wrong error
 
-let globalPreloadWarned = false;
 class Hooks {
   #chains = {
     /**
@@ -162,12 +161,9 @@ class Hooks {
     } = pluckHooks(exports);
 
     if (globalPreload && !initialize) {
-      if (globalPreloadWarned === false) {
-        globalPreloadWarned = true;
-        emitExperimentalWarning(
-          '`globalPreload` will be removed in a future version. Please use `initialize` instead.',
-        );
-      }
+      emitExperimentalWarning(
+        '`globalPreload` is planned for removal in favor of `initialize`. `globalPreload`',
+      );
       ArrayPrototypePush(this.#chains.globalPreload, { __proto__: null, fn: globalPreload, url });
     }
     if (resolve) {

diff --git a/test/es-module/test-esm-loader-hooks.mjs b/test/es-module/test-esm-loader-hooks.mjs
@@ -424,10 +424,22 @@ describe('Loader hooks', { concurrency: true }, () => {
       const { stderr } = await spawnPromisified(execPath, [
         '--experimental-loader',
         'data:text/javascript,export function globalPreload(){}',
+        '--experimental-loader',
+        'data:text/javascript,export function globalPreload(){return""}',
+        fixtures.path('empty.js'),
+      ]);
+
+      assert.strictEqual(stderr.match(/`globalPreload` is an experimental feature/g).length, 1);
+    });
+
+    it('should not emit deprecation warning when initialize is supplied', async () => {
+      const { stderr } = await spawnPromisified(execPath, [
+        '--experimental-loader',
+        'data:text/javascript,export function globalPreload(){}export function initialize(){}',
         fixtures.path('empty.js'),
       ]);
 
-      assert.match(stderr, /`globalPreload` will be removed/);
+      assert.doesNotMatch(stderr, /`globalPreload` is an experimental feature/);
     });
 
     it('should handle globalPreload returning undefined', async () => {