Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: top level domain set in the cookie #166

Merged
merged 2 commits into from
Jun 3, 2024
Merged

feat: top level domain set in the cookie #166

merged 2 commits into from
Jun 3, 2024

Conversation

zeelrupapara
Copy link
Contributor

Issue

Changes

  • Set the TLD domain in the cookie
  • Also add some test cases
  • TLD becomes a wild card entry so a cookie can easily be set in other sub-domains and it's not allowed to set in other domains so cookie security remains as it is.

@vercel Vercel
Copy link

vercel bot commented May 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-plugins ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2024 11:56am

@zeelrupapara zeelrupapara mentioned this pull request Jun 2, 2024
Closed
@adrien2p adrien2p merged commit c226927 into adrien2p:main Jun 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeelrupapara @adrien2p