Remove usage of jquery in components #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
offirgolan
requested changes
Jul 28, 2018
vendor/closest-polyfill.js
Outdated
| @@ -0,0 +1,19 @@ | |||
| // https://developer.mozilla.org/en-US/docs/Web/API/Element/closest | |||
|
|
|||
| if (typeof FastBoot === 'undefined') { | |||
There was a problem hiding this comment.
@josemarluedke this polyfill is pretty sketchy since it will end up in the host app. Can we instead transform this into a utility method that the addon can leverage?
josemarluedke
force-pushed
the
remove-jquery-usage-of-components
branch
from
f80b71b
to
b45649b
Compare
josemarluedke
force-pushed
the
remove-jquery-usage-of-components
branch
from
b45649b
to
be2f7a1
Compare
|
@offirgolan Pull request updated. Please take a look again. |
offirgolan
approved these changes
Jul 30, 2018
|
@josemarluedke awesome! Thank you for taking the time to do this 😄 |
|
Released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial implementation for #105.
There are jquery usage in the test helper
triggerSwipeEventthat I haven't figure out a migration yet, but it would be awesome if we can get this merged in.