Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Exclude .git files from console warnings #7332

Merged
merged 2 commits into from
Mar 27, 2014
Merged

Conversation

zaggino
Copy link
Contributor

@zaggino zaggino commented Mar 26, 2014

Ping @iwehrman
Related issues:
#6803 (edit)
brackets-userland/brackets-git#289

@peterflynn
Copy link
Member

@zaggino This is about #6803, right? The issue is more general than just .git folders -- it applies to anything screeened out by the FileSystem watch rot's filter. So we might want to do a more general fix here...

@zaggino
Copy link
Contributor Author

zaggino commented Mar 26, 2014

Ah yes, this is the same thing. I don't know how to do a more general fix here though. Ideas?

@iwehrman
Copy link
Contributor

It's probably fine to just remove the warning. It's not an unexpected or, AFAICT, harmful condition.

@peterflynn
Copy link
Member

@iwehrman That seems fair too. I'll leave #6803 open though since it seems like ideally, we'd also avoid the cost of attempting to stat each file inside .git (or any other filtered subtree) when there's churn going on in there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants