Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

[JSLint] Respects tabSize setting when useTabChar is true #7243

Merged
merged 2 commits into from
Mar 21, 2014

Conversation

zaggino
Copy link
Contributor

@zaggino zaggino commented Mar 18, 2014

function _getIndentSize() {
return PreferencesManager.get("useTabChar") ? PreferencesManager.get("tabSize") : PreferencesManager.get("spaceUnits");
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already fixed this in PR #7186, but the file path should be passed to PreferencesManager.get():

    function _getIndentSize(fullPath) {
        return PreferencesManager.get(
            PreferencesManager.get("useTabChar", fullPath) ? "tabSize" : "spaceUnits",
            fullPath
        );
    }

Then pass "fullPath" to this function below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I can update once #7186 gets merged or you can close this and include it there.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem. Proceed with this fix and we can merge changes when necessary.

@zaggino
Copy link
Contributor Author

zaggino commented Mar 20, 2014

@redmunds Fixed with 3b60d0d

@redmunds
Copy link
Contributor

Looks good. Merging.

redmunds added a commit that referenced this pull request Mar 21, 2014
[JSLint] Respects tabSize setting when useTabChar is true
@redmunds redmunds merged commit c52bffe into master Mar 21, 2014
@redmunds redmunds deleted the zaggino/issue-7240 branch March 21, 2014 18:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants