This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fix issue with invalid hint hiding after code was changed #7235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| editor.hint.css("display", "none"); | ||
| editor.hintShown = false; | ||
| if (!editor.hintShown) { | ||
| editor.hint.css("display", "none"); |
There was a problem hiding this comment.
Why not .hide(); instead of .css("display", "none"); ?
https://api.jquery.com/hide/
There was a problem hiding this comment.
This just refactors the existing code, so I think it's ok.
|
Looks good. I don't think anyone would have ever hit that -- I had to make transition-duration 6s to verify :) Merging. |
redmunds
added a commit
that referenced
this pull request
Mar 19, 2014
…hint-animation-fix Fix issue with invalid hint hiding after code was changed
marcelgerber
deleted the
inline-timing-function-editor-hint-animation-fix
branch
|
I was able to hit it without editing any duration. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #7233
The code may not be the best, but I'm not used to promises.