This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Enable image viewer for .ico files #7201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -312,7 +313,11 @@ define(function (require, exports, module) { | |||
| $("#img-preview").on("load", function () { | |||
| // add dimensions and size | |||
| _naturalWidth = this.naturalWidth; | |||
| var ext = FileUtils.getFileExtension(fullPath); | |||
There was a problem hiding this comment.
Is there a better approach to get the file extension (maybe passed through)?
There was a problem hiding this comment.
This line seems reasonable to me. It's not going to be a performance bottleneck, if that's the concern...
|
Looks good. Merging. |
RaymondLim
added a commit
that referenced
this pull request
Mar 19, 2014
Enable image viewer for .ico files
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #7017 @peterflynn @larz0
This adds
.icofiles to the image language and attaches alargestlabel to a shown ico file (as discussed in the issue).