This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Style Extension Update buttons to the match the green notification "badge" #6315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| // Update Button Type | ||
| &.update { | ||
| background-color: #91cc41; | ||
| border-color: #658e2d; |
There was a problem hiding this comment.
Let's use #65A015 for border-color.
|
Thanks for this PR @stowball, the usability is much better now. |
|
@stowball still up for this? |
|
@larz0 Still up for it? What do you mean? I'd love it if you merged it :) |
|
@redmunds Ah, sorry. I thought they were changes that you guys wanted to make! I've made them now. Sorry! |
|
Great! UX review done. Thanks @stowball! |
| box-shadow: inset 0 1px 0 rgba(255, 255, 255, 0.27); | ||
| color: #fff; | ||
| font-weight: @font-weight-semibold; | ||
| text-shadow: 0 -1px 0 rgba(0, 0, 0, 0.24) ; |
There was a problem hiding this comment.
Tiny nit: space before semicolon
|
Looks great! I'll just fix the nit after merging. |
njx
added a commit
that referenced
this pull request
Apr 1, 2014
Style Extension Update buttons to the match the green notification "badge"
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an extension has an update, it would be a much better user experience for the Update button to be clearly differentiated in the list (and especially from the Remove button).
Thus, this pull request changes .btn.update to match the green of the notification badge.