[CQ-4347128] add thankyoumessage & thankyoupage post submit for headless #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amit-mnnit
changed the title
vdua
reviewed
Aug 25, 2022
| if(thankyouPage){ | ||
| window.open(thankyouPage, '_blank'); | ||
| }else if(thankyouMessage){ | ||
| alert(thankyouMessage); |
There was a problem hiding this comment.
How to show thankyouMessage?
vdua
reviewed
Aug 25, 2022
| const thankyouMessage = state?.properties?.['afs:thankyouMessage']; | ||
| const thankyouPage = state?.properties?.['afs:thankyouPage']; | ||
| if(thankyouPage){ | ||
| window.open(thankyouPage, '_blank'); |
There was a problem hiding this comment.
Instead of opening a new window, we should change the URL in the same window
vdua
reviewed
Aug 25, 2022
| const onSubmit= (action: Action) => { | ||
| const state = action.target.getState(); | ||
| const thankyouMessage = state?.properties?.['afs:thankyouMessage']; | ||
| const thankyouPage = state?.properties?.['afs:thankyouPage']; |
There was a problem hiding this comment.
use action.payload. It will not be part of properties.
There was a problem hiding this comment.
There is no setup of the test cases in "ui.frontend.react.forms.af"
rismehta
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add thankyoumessage & thankyoupage post submit for headless
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: