CIF-2842 - Extend List component to list pages by product or category #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added proxy component for commerce list
buuhuu
reviewed
Aug 3, 2022
| @@ -0,0 +1,8 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <jcr:root xmlns:sling="http://sling.apache.org/jcr/sling/1.0" xmlns:cq="http://www.day.com/jcr/cq/1.0" xmlns:jcr="http://www.jcp.org/jcr/1.0" | |||
There was a problem hiding this comment.
As the CIF list is a dropin replacement, wouldn't it make more sense to change the resource type of the normal list component when cif is enabled?
This is the way it was done for button https://github.com/adobe/aem-project-archetype/blob/d322424553beeefd1c689cfbeda9608f36509275/src/main/archetype/ui.apps/src/main/content/jcr_root/apps/__appId__/components/button/.content.xml
|
I think we also have to increase the cif sdk api version in the parent pom: |
* replace existing list proxy to point to commerce list for commerce projects
* updated aem.cif.sdk.api to 2022.08.02.00
|
aem.cif.sdk.api increased |
buuhuu
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added proxy component for commerce list.
Related Issue
CIF-2842
How Has This Been Tested?
Manually.
Types of changes
Checklist: